Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authority router #221

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Add authority router #221

merged 1 commit into from
Dec 30, 2024

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Dec 28, 2024 •
edited
Loading

Should be relatively straightforward, just a clone of the path router, but "." instead of "/" as the delimiter. No optional groups. Different parser, etc.

Not worried about performance here - since long term we'll use the typestate pattern to reduce the number of useless branches we're hitting.

@CathalMullan CathalMullan linked an issue Dec 28, 2024 that may be closed by this pull request
Investigate "authority" routing. #11
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.44440% with 867 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/router/authority/search.rs 38.75% 147 Missing and 11 partials ⚠️
src/router/authority/insert.rs 34.59% 133 Missing and 5 partials ⚠️
src/router/authority/delete.rs 0.00% 109 Missing ⚠️
src/router/authority/state.rs 35.25% 98 Missing and 3 partials ⚠️
src/router/authority/find.rs 27.05% 60 Missing and 2 partials ⚠️
src/router/authority.rs 60.28% 51 Missing and 5 partials ⚠️
src/router/authority/parser.rs 88.05% 39 Missing and 4 partials ⚠️
src/router/authority/optimize.rs 61.79% 30 Missing and 4 partials ⚠️
src/router/authority/errors/delete.rs 0.00% 30 Missing ⚠️
src/router/authority/display.rs 65.67% 10 Missing and 13 partials ⚠️
... and 16 more
Files with missing lines Coverage Δ
src/chain.rs 100.00% <100.00%> (ø)
src/decode/punycode.rs 91.27% <ø> (ø)
src/errors/encoding/percent.rs 100.00% <100.00%> (ø)
src/errors/encoding/punycode.rs 100.00% <100.00%> (ø)
src/errors/route.rs 94.73% <100.00%> (-3.27%) ⬇️
src/lib.rs 67.79% <ø> (ø)
src/router/authority/id.rs 100.00% <100.00%> (ø)
src/router/path/delete.rs 96.36% <100.00%> (+0.17%) ⬆️
src/router/path/errors/template.rs 98.90% <100.00%> (ø)
src/router/path/find.rs 95.29% <100.00%> (+0.23%) ⬆️
... and 28 more

... and 3 files with indirect coverage changes

@CathalMullan CathalMullan force-pushed the 11-investigate-authority-routing branch from 1fed6ea to 781b1c9 Compare December 28, 2024 02:39
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #221 will degrade performances by 18.28%

Comparing 11-investigate-authority-routing (63931aa) with main (227aa6f)

Summary

❌ 4 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 11-investigate-authority-routing Change
❌ gitlab delete benchmarks/wayfind 110.9 ms 135.7 ms -18.28%
❌ gitlab display benchmarks/wayfind 9.9 ms 10.3 ms -4.27%
❌ matchit benchmarks/wayfind 14.1 µs 15.4 µs -8.32%
❌ path-tree benchmarks/wayfind 73.4 µs 80.8 µs -9.11%

@CathalMullan CathalMullan force-pushed the 11-investigate-authority-routing branch 11 times, most recently from fb2c608 to 6e6208a Compare December 30, 2024 15:03
@CathalMullan CathalMullan force-pushed the 11-investigate-authority-routing branch from 6e6208a to 63931aa Compare December 30, 2024 15:16
@CathalMullan CathalMullan marked this pull request as ready for review December 30, 2024 15:21
@CathalMullan CathalMullan merged commit 2f208f7 into main Dec 30, 2024
7 of 8 checks passed
@CathalMullan CathalMullan deleted the 11-investigate-authority-routing branch December 30, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate "authority" routing.
1 participant
@CathalMullan